2808: HISTORY_ID in DIFFVIEWER_DIFFSET is not filled if Review Request was created without diff and diff was uploaded later

lg.and******@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 23, 2014
What version are you running?
1.6.14

What's the URL of the page containing the problem?
------

What steps will reproduce the problem?
1. Create Review Request without uploading diff
2. Upload new diff to the newly created request
3. Check the DIFFVIEWER_DIFFSET table - HISTORY_ID field is NULL
4. Try to add comemnts to the uploaded diff - comments will be gone after the page refresh

What is the expected output? What do you see instead?
3. HISTORY_ID field is filled with value
4. Diff code comments are correctly saved / preserved

What operating system are you using? What browser?
Server: Ubuntu 11.10 & Apache & Python  2.7.2
Client: Windows 8, Chrome 25

Please provide any additional information below.

Affects also Review Request creation through the API - in this case Review Request is created before Diffs are uploaded
david
#1 david
  • +Component-API
david
#2 david
This has been fixed for a while.
  • +Fixed