280: Missing P4 password in perforce.py get_file method

rasmus.m********@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 4, 2007 
What steps will reproduce the problem?
1. simply use a password protected user for the review-board

Please provide any additional information below.
Patch to fix the problem is attached
p4_pass.diff 
Index: scmtools/perforce.py
===================================================================
--- scmtools/perforce.py	(revision 992)
+++ scmtools/perforce.py	(working copy)
@@ -70,7 +70,7 @@
             file = '%s#%s' % (path, revision)
 
         p = subprocess.Popen(
-            ['p4', '-p', self.p4.port, '-u', self.p4.user, 'print', '-q', file],
+            ['p4', '-p', self.p4.port, '-u', self.p4.user, '-P', self.p4.password, 'print', '-q', file],
             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 
         (res, errdata) = p.communicate()
david
#1 david 
Fixed in SVN HEAD.  Thanks!
  • +Fixed
  • +Component-SCMTools