2795: AddComment Button doesn't work.
- Fixed
- Review Board
| fabien.*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Dec. 30, 2012 |
What version are you running? 1.6.13 What's the URL of the page containing the problem? Local server, sorry. What steps will reproduce the problem? 1.Create a review. 2.Attach a file. 3.Press Add Comment on the file. What is the expected output? What do you see instead? Expected: The Comment dialog box to show up. Result: The page simply scroll up to the top. What operating system are you using? What browser? Windows. Reproduce on Chrome, IE 8 and Firefox. Please provide any additional information below. It just seems that the button doesn't get attach.
Are there any JavaScript errors? Can you open the console (Control-Shift-J) on Chrome, reload the page, reproduce the problem, and see any errors there?
-
+ NeedInfo
I got nothing. No error at all. Both the <li> and the <a> elements have no script attach to it (in the on* attributes), and there is only two listeners for the click and live events on the document node.
Here the div section as seen by ChromeOS:
<div class="content clearfix">
<label for="file-list">File Attachments:</label>
<div id="file-list">
<div class="file-container" data-file-id="1">
<div class="file">
<ul class="actions">
<li class="file-add-comment"><a href="#">Add Comment</a></li>
</ul>
<div class="file-header">
<a href="/reviewboard/media/uploaded/files/2012/11/07/Broadcast_Messaging.pptx">
<img src="/reviewboard/media/rb/images/mimetypes/text-x-generic.png?1352332777">
Broadcast_Messaging.pptx</a>
</div>
<div class="file-caption">
<a href="/reviewboard/media/uploaded/files/2012/11/07/Broadcast_Messaging.pptx" class="edit">Broadcast Presentation</a>
</div>
</div>
</div>
<br clear="both">
</div>
</div>
-
+ Component-Reviews
This was changed quite a bit in the run-up to 1.7. I believe this is fixed now.
-
- NeedInfo + Fixed