2792: Error Uploading svn diff file with property changes or binary files
- Fixed
- Review Board
karl.******@gmx*** (Google Code) (Is this you? Claim this profile.) | |
Jan. 20, 2014 |
What version are you running? RB 1.6.13 RBTools 0.4.2 What's the URL of the page containing the problem? na What steps will reproduce the problem? 1. create svn repository 2. add to folders in repo root f1 and f2 3. add file with text to f1 and commit 4. checkout f2 and merge changes from f1 into the working copy 5. use "svn diff --show-copies-as-adds . > f2.diff" to create diff file 6. call post-review to create review request ("post-review --server=http://path/to/server/ -d --diff-filename=f2.diff -p What is the expected output? What do you see instead? Expected: Create new Review Request and add diff file What happens: post-review reports an error uploading the diff (API Error 105). Post Review Error: ============================ >>> Got API Error 105 (HTTP code 400): One or more fields had errors >>> Error data: {u'fields': {u'path': [u"URL 'http://path/to/server/svn/sandbox/review' refers to a directory\nCan't get text contents of a directory"]}, u'st at': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Error uploading diff The generated diff file was empty. This usually means no files were modified in this change. ============================ Diff file: see attachment What operating system are you using? What browser? Win7 / Win Server 2k3 Firefox 16 Please provide any additional information below. If you add a step 4a. and remove the svn:merge property it will work. If you add a binary file to f1 in Step 3 it wont work, even if the svn:merge property is removed. As far as I understood Issue 2359 (http://code.google.com/p/reviewboard/issues/detail?id=2359) and Issues 2561 (http://code.google.com/p/reviewboard/issues/detail?id=2561, merged into 2359), this should work. Or did I do something wrong? Thanks in advance, Karl
Hi, it seems this is only a language problem. If you set the enviroment variable LANG to "en_US" everything works just fine :) (Tested with RB 1.7rc1). Karl
RBTools now executes svn with LC_ALL and LANGUAGE set to en_US.UTF-8. I don't think we can support every translation of every property name that svn sticks in diffs.
-
+ Fixed
Thanks!