2789: diff -uN /dev/null new-file is not accepted as a diff

torsten.e*********@web*** (Google Code) (Is this you? Claim this profile.)
Oct. 30, 2012 
What version are you running?
Web interface (1.6.6)

What's the URL of the page containing the problem?
https://git.reviewboard.kde.org/r/new/

What steps will reproduce the problem?
1. Create a diff for a new file with 'diff -uN /dev/null new-file >new-file.diff'
2. Upload to the URL above
3. Click "Create Review Request"

What is the expected output? What do you see instead?
The file should either be accepted OR the error message shall explain WHY it is not accepted AND what to do to create a diff that will be accepted.
The error message is "The selected file does not appear to be a diff." instead :/

What operating system are you using? What browser?
Does not matter

Please provide any additional information below.
Have a good day and enjoy life!
        =|o)
chipx86
#1 chipx86 
The error could certainly use some improvement, but the issue you're hitting is that you're not generating a valid diff as far as the Git support is concerned. It has to be a git diff, and not a plain unified diff, as a Git diff has various bits of information we require (such as revision information).

Try making a branch, add the file, commit, then post-review that branch.
  • +NotABug