2785: The post-review cannot create new review request for a svn working copy when I install both the svn client and the perforce client on my machine

zhangwen********@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 23, 2014
What version are you running?
RBTools 0.4.2

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Change the current directory to a svn working copy, make some change on a versioned file
2. Type post-review
3. Wait for a while, an error occurs.

What is the expected output? What do you see instead?
A new review quest should be created, but instead, error messages outputted:
Failed to execute command: ['p4', 'opened', '-c', 'default']
['Your session has expired, please login again.\n']

What operating system are you using? What browser?
Windows7, FireFox 16

Please provide any additional information below.
Seems the post-review checks the perforce client prior to the svn client, it picks up the perforce client even when the current directory is in a svn working copy.

When I used RBTools 0.3.4 before, it can create new review request in a svn working copy, seems it checks the svn client prior to the perforce client.

I expect that the post-review can select the correct SCM client when the current directory is inside a work copy of a SCM repo, or it can give me an option to explicitly specify the SCM client.
david
#1 david
  • +Component-RBTools
#2 gibso*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I am getting the same error in Linux. Please respond to this defect
david
#3 david
This is fixed in rbtools release-0.5.x (4c39641), and will ship in 0.5.6
  • +Fixed