278: Request keeping review window open on "Save Draft"
- WontFix
- Review Board
| ryan.ga*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Nov. 24, 2007 |
What steps will reproduce the problem? 1. Press the Review link 2. Enter a review comment in the pop-up window 3. Hit Save Draft. What is the expected output? What do you see instead? I expect the draft to be saved and not have the pop-up window closed. This would match with the behavior of the diff comment's window. What operating system are you using? What browser? WinXPsp2/Firefox2.0.0.8
When you save a review in the comment dialog, you're taken to the review page as well. I don't believe the behavior is any different?
-
+ Component-DiffViewer
I actually intended saving a diff comment not a review draft in the diff comment window. So open a diff comment window, type in a comment, hit save -- the window is still open. Now click on the "Review" tab in that window, type in a review comment, hit "Save Draft", the window automatically closes. This is the difference of which I speak. It probably just comes down to personal preference, but I'd rather see this window stay open until I explicitly close it. Saving a diff comment or a review comment should behave the same to me.
The difference is that when you're saving comments, you're usually saving multiple in one session, so the window should stay up. When you save a review, that means you're done with the comments and the diff. There should never be any reason why you'd want to save multiple reviews for one diff, one after another. It's more common that people would want to see the final review and be back at the review request than to keep the diff viewer open, since they're usually "done" with it once they finish the review. I don't want to add a preference for this because it's just pref bloat and I don't believe it'd be used much. Still, I'll keep this open for further discussion for now.
-
+ WontFix -
- Priority-Medium + Priority-Low