2774: Wrong identification of python functions in folds

mola*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 23, 2012
What version are you running?
1.6.6

What's the URL of the page containing the problem?
/r/#/diff/

What steps will reproduce the problem?
1. Open diffs for long python files where code is folded (before a diff)
2.
3.

What is the expected output? What do you see instead?
- When code is folded, the interface shows one line saying in which function we currently are at the end of the fold. Something like:

90 lines hidden [Expand]
def spamalot(...):

It happened quite a few times that the function named there was not the actual "current" one, other functions being declared both before and after this one, inside of the fold.

This is misleading. It would actually be preferable not to have this information altogether, rather than having it be wrong.

What operating system are you using? What browser?
Win7 Pro 64bits - Chrome 15.0.874.106

Please provide any additional information below.
chipx86
#1 chipx86
If you can provide a diff that demonstrates this that we can use for testing, that would help a lot. Or figure out if there's something special about those functions that are skipped over.

We use Review Board to review Review Board, which is in Python, and I haven't come across this.
  • +NeedInfo
#2 mola*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'm sorry I can't. The code I've been using is for work, and my employer will not let me send any snippet outside.

I think it may have to be with some methods starting with an underscore. I'll try to find more tomorrow.
david
#3 david
Any more information you can give us about the reproduction case?
#4 mola*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'm sorry, I did not reproduce it with a diff I could send you.
david
#5 david
Without a reproduction case, I don't think there's anything we can do. Please reopen this if you can narrow it down further.
  • -NeedInfo
    +Incomplete