276: Uploading 2nd diff to review results in 'Unable to parse server response' message
- UnableToReproduce
- Review Board
| d.anthony*********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Dec. 19, 2007 |
What steps will reproduce the problem? 1. Create a review request. 2. Modify the local file, creating a 2nd, slightly different diff. 3. Click on the 'Upload Diff' on the review. What is the expected output? What do you see instead? Expected: The new diff should be uploaded and the review updated. Actual: The upload widget reports 'Unable to parse server response', but the diff appears to be uploaded. (Clicking on the View Diff link shows the new diff, but the review is also put into "Draft" state and must be published again.) What operating system are you using? What browser? Linux, Mozilla-firefox, with subversion back-end. Please provide any additional information below. We only seem to see this when trying to upload an updated diff to an existing review. Haven't seen this error on initial review request creation.
I'm running into this as well, using Safari 3 on Mac OS X 10.4 and 10.5. I see it on uploading image
attachments as well.
I did a tcpdump to see what the server was sending. This is what I saw:
HTTP/1.1 200 OK
Date: Thu, 08 Nov 2007 20:19:44 GMT
Server: Apache/2.2.3 (Ubuntu) mod_fastcgi/2.4.2 mod_python/3.2.10 Python/2.5.1c1
Expires: Thu, 08 Nov 2007 20:19:44 GMT
Vary: Cookie
Last-Modified: Thu, 08 Nov 2007 20:19:44 GMT
ETag: 7536ad7be03a99c96f4507483a271f41
Cache-Control: max-age=0
Keep-Alive: timeout=15, max=100
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/plain; charset=UTF-8
23
{"stat": "ok", "diffset_id": 12450}
It's the 23 that's throwing it off. That's strange. It shouldn't be outputting that...
-
- Priority-Medium + Priority-High + Component-API
I think the 23 is from the HTTP chunked encoding used for 1.1 keepalive connections. 0x23 is 35, which is the number of bytes in the response body.
I just updated to r1030, and I'm not seeing this anymore. I'm able to upload a 2nd diff without any error messages.
Not sure whether we should close this then or keep it open in case someone else encounters this. I don't know what would have fixed it.
Going to close, since nobody's reported this in a while. Please reopen if you continue to see it.
-
+ UnableToReproduce
I could reproduce the problem. The message 'Unable to parse server response' could be seen when uploading images. The problem was fixed by making the folder reviewboard/htdocs/images/uploaded writable (at least for the apache user). I hope this helps.