274: Exception with REQUIRE_SITEWIDE_LOGIN = True

cuv****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 26, 2007
What's the URL of the page containing the problem?
/r/##/

What steps will reproduce the problem?
1. Set REQUIRE_SITEWIDE_LOGIN = True
2. Try to view a review request, whether logged in or not.
3. Stare at the exception. :(

What is the expected output? What do you see instead?
Expect either to display the review or redirect to a login page.

Instead, get an exception as follows:

Traceback (most recent call last):
File "<path>/reviewboard/django/core/handlers/base.py" in _real_get_response
  81. response = callback(request, *callback_args, **callback_kwargs)
File "<path>/reviewboard/reviews/views.py" in _check
  58. return login_required(view_func, *args, **kwargs)

  TypeError at /r/98/
  new_decorator() takes exactly 1 non-keyword argument (2 given)

What operating system are you using? What browser?
Client: WinXP SP2, Firefox 2.0.0.8
Server: Python 2.4.3, Review Board r987, Django r6601, djblets r11651
chipx86
#1 chipx86
  • -Priority-Medium
    +Priority-Furious
    +Component-Reviews
chipx86
#2 chipx86
Not sure when this broke but it's fixed now. Added unit tests so we'll catch this in
the future.
  • +Fixed