2711: Unable to "fix" issue
- Fixed
- Review Board
| mailkar********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Aug. 3, 2013 |
What version are you running? 1.6.11 What steps will reproduce the problem? 1. Open any review on review board with Google Chrome 21.0.1180.79 2. Let a reviewer open an issue (with some comments) 3. The reviewee tries to click 'Fix' button. What is the expected output? What do you see instead? I expect the Fix button to change the status of the issue from open to fixed. Instead, the button grays out and refreshing the page gets it back to ungreyed. What operating system are you using? What browser? Windows 7 (64-bit) and Google Chrome 21.0.1180.79
I am getting this issue as well on firefox - 14.0.1
The javascript console does indeed have errors.
I am running reviewboard 1.6.6.
Upon clicking the fixed button 3 ajax requests come back from the looks of it successful:
GET (url1) 304 NOT MODIFIED
GET (url2) 304 NOT MODIFIED
GET (url3) 304 NOT MODIFIED
But the final one fails:
PUT (url3 again - without get information) 403 FORBIDDEN
the json response is:
{"stat": "fail", "err": {"msg": "You don't have permission for this", "code": 101}}
Afterwords there is another javascript error:
TypeError: rsp.diff_comment is undefined
[Break On This Error]
this.id = rsp.diff_comment.id;
-
+ Component-Reviews
I'm getting this issue as well in IE (version 9.0.8112.16421), Chrome (version 27.0.1453.116) and Firefox (version 12). I was able to consistently reproduce this issue in Firefox by clicking the diff revision code link ( like http:://svn/mystuff/mycode.cpp ), clicking back and selecting Fixed. The fixed button is greyed out. If I delete my browser history and cookies the Fixed button works correctly again until I navigate to the diff. When I get this error in Chrome the error is 403 Forbidden. I also see the following: Uncaught TypeError: Cannot read property 'id' of undefined datastore.js:160 $.extend._loadDataFromResponse datastore.js:160 rbApiCall.success datastore.js:86 $.extend.error datastore.js:2025 o.extend.handleError jquery-1.3.2.min.js:19 N