2667: post-review fails to load .reviewboardrc on NFS automounted homes

nelson.s*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 4, 2014
What version are you running?

RBTools-0.4.1-py2.6.egg

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?
1. easy_install -U RBTools as root
2. cd ~/someproject 
3. post-review ...

What is the expected output? What do you see instead?

Review posted, instead:

Traceback (most recent call last):
  File "/usr/local/bin/post-review", line 8, in <module>
    load_entry_point('RBTools==0.4.1', 'console_scripts', 'post-review')()
  File "/usr/local/lib64/python2.6/site-packages/RBTools-0.4.1-py2.6.egg/rbtools/postreview.py", line 1195, in main
  File "/usr/local/lib64/python2.6/site-packages/RBTools-0.4.1-py2.6.egg/rbtools/utils/filesystem.py", line 51, in load_config_files
  File "/usr/local/lib64/python2.6/site-packages/RBTools-0.4.1-py2.6.egg/rbtools/utils/filesystem.py", line 39, in _load_config
IOError: [Errno 21] Is a directory: '/emc/.reviewboardrc'

Where /emc is the automount base directory for the NFS mounts.
The real home is /emc/<user>

What operating system are you using? What browser?

SuSE SLES 11 SP1

Please provide any additional information below.

This patch solves it:

--- rbtools/utils/filesystem.py 2012-07-12 11:52:54.000000000 -0400
+++ rbtools/utils/filesystem.py.old     2012-02-29 00:28:42.000000000 -0500
@@ -34,7 +34,7 @@

         filename = os.path.join(path, CONFIG_FILE)

-        if os.path.exists(filename) and not os.path.isdir(filename):
+        if os.path.exists(filename):
             try:
                 execfile(filename, config)
             except SyntaxError, e:
david
#1 david
  • +PendingReview
  • +Component-RBTools
david
#2 david
  • -PendingReview
    +Fixed