266: Use of JavaScript in "View Review Request" link is obnoxious

mark*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Nov. 24, 2007 
At http://reviews.review-board.org/r/171/diff/#index_header, command-clicking on "View Review 
Request" to open the link in a new tab results in both the new and existing tab loading the page.  
This occurs because the link executes some JavaScript in response to the click.  The JavaScript 
seems completely unnecessary.
chipx86
#1 chipx86 
The reason for this is that the "button" is an <li> and we can't link that, so we use
some javascript to duplicate the effects of the link. But yes, we need to rethink how
to do this so that we don't do anything differently than a standard link.
  • +Component-Reviews
  • +chipx86
chipx86
#2 chipx86
  • +Fixed