2655: Email being sent for comment with 0 character length
- Fixed
- Review Board
| trupti******@xyrat****** (Google Code) (Is this you? Claim this profile.) | |
| Jan. 22, 2014 |
What version are you running? 1.6.3 What's the URL of the page containing the problem? http://reviewboard.clusterstor.com/r/802/ What steps will reproduce the problem? 1. Click on "Add comment" 2. Type something and then delete whatever is typed 3. Since no comment is added as a result, no email should be generated. But an email is generated that gives an impression that 0 character length comment is added. What is the expected output? What do you see instead? Since no comment is added, email should not be generated or no indication should be given of a comment being added that specific line. But in reality, an indication is given that a comment is added though with no characters in it. What operating system are you using? What browser? MAC 10.6.8, Mozilla Firefox OR Chrome Please provide any additional information below.
Can you try upgrading the server? I believe this was fixed in one of the later 1.6.x point releases.
-
+ NeedInfo
Hi, Thanks for your comment. The thing is our currently setup server is being used for multiple projects altogther, involving too many engineers. Hence an upgrade is not we can try out without any justified reason. Hence, I will appreciate if you can provide the version number in which this issue is fixed. Thanks much. Regards, Trupti
Hrm. The change I was thinking of was released in 1.6.2, so that's not it. I'm a little confused by the reproduction steps--cancelling the first comment dialog shouldn't be creating a draft, so there should be nothing to publish, thus no email. Can you clarify the steps?
>> cancelling the first comment dialog shouldn't be creating a draft, so there should be nothing to publish, thus no email. Correct. In fact the "publish" option should be made unavailable when the comment dialogue is made empty followed by a clock on "OK". To simplify the reproduction, try this: 1) Open one review request. 2) Add one genuine comment 3) At some other line, (i) click on "Add comment" at say line x, type something say 5 characters, click OK. (ii) The comment appears there on line x and the "publish" option is now visible. (iii) Now move at some other line say y, type something say 10 characters, click OK (iv) Now, delete all those 10 characters which are part of the comment at line y and click OK (v) Now click "publish" As a result of publish, an email is generated. This email should only talk about the comment added at line x and it should not talk anything about comment that was attempted to be added at line y. But in reality, the email would talk about comment added at line x with 5 characters and it will also indicate that comment was added at line y though with 0 characters! Hope that helps.
Along with some corrections with the steps: To simplify the reproduction, try this: 1) Open one review request. 2) Click on "Add comment" at say line x, type something say 5 characters, click OK. 3) The comment appears there on line x and the "publish" option is now visible. 4) Now move at some other line say y, type something say 10 characters, click OK 5) Now, delete all those 10 characters which are part of the comment at line y and click OK 6) Now click "publish" As a result of publish, an email is generated. This email should only talk about the comment added at line x and it should not talk anything about comment that was attempted to be added at line y. But in reality, the email would talk about comment added at line x with 5 characters and it will also indicate that comment was added at line y though with 0 characters! Hope that helps.
Hi Team, Could this issue be reproduced in-house? Thanks, Trupti
-
+ Component-EMail
-
- NeedInfo + New
This is fixed in the 2.0 betas (and possibly before then). You can no longer save zero-length comments (it forces you to "delete" it).
-
- New + Fixed