2651: Reviewboard fails to upload diff when checking in binaries and code in the same revision

li**@idle-ga******* (Google Code) (Is this you? Claim this profile.)
Sept. 29, 2012
What version are you running?
1.6.6

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. check in binaries and code changes in the same svn revision
2. watch reviewboard try to upload diff of the binary and error out:
Got API Error 207 (HTTP code 400): The file was not found in the repository

3.

What is the expected output? What do you see instead?
The file is in fact there, but it's a binary. Sounds like it shouldn't try to diff it.
And should error out with unrelated message.

What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david
How are you creating the diff?
  • +NeedInfo
david
#2 david
  • -NeedInfo
    +Incomplete