2639: Appending 'undefined' to options.path

ddu****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 12, 2012 
What version are you running?
1.6.9

What's the URL of the page containing the problem?
https://reviewboard.apache.org

What steps will reproduce the problem?
    _apiCall: function(options) {
        var self = this;
        
        options.prefix = this.prefix;
        options.path = "/review-requests/" + this.id + options.path;
        
        if (!options.success) {
            options.success = function() {
                window.location = self.path;
            };
        }
        
        rbApiCall(options);
    }

I think you mean for the line to be:
options.path = "/review-requests/" + this.id + (options.path || '');

I see 'undefined' being appended to the path member of the options object.
#2 ddu****@gmai***** (Google Code) (Is this you? Claim this profile.) 
datastore.js:655 (in my browser, anyway)
datastore.js:840 has this technique already employed.
david
#3 david 
This has since been fixed.
  • +Fixed