2619: Using snapshot view, Error was occurred from Diff viewer. (clear case and post-reivew)

raje****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 20, 2013 
What version are you running?
 - Reviewboard : 1.6.4.1
 - RBTools : 0.4.1

   ※ SCM tool : ClearCase

What's the URL of the page containing the problem?
 - http://Reviewboard/r/80/diff/#index_header

What steps will reproduce the problem?
1. When i click Diff button., error was occurred. 
   I used RBTools.. and snapshot view.
   error string is....

The patch to 'M:/reviewboard/testtestvob/test1/Test3/RB Test_testtestvob.txt@@/main/CHECKEDOUT' didn't apply cleanly. The temporary files have been left in 'c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7' for debugging purposes. `patch` returned: patching file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8 Patch attempted to create file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8, which already exists. Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8-new.rej 

Traceback (most recent call last):
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\views.py", line 158, in view_diff
    interdiffset, highlighting, True)
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1096, in get_diff_files
    large_data=True)
  File "c:\python25\lib\site-packages\Djblets-0.6.16-py2.5.egg\djblets\util\misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1095, in <lambda>
    enable_syntax_highlighting)),
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 570, in get_chunks
    new = get_patched_file(old, filediff)
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 388, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File "C:\Python25\lib\site-packages\reviewboard-1.6.4.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 256, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'M:/reviewboard/testtestvob/test1/Test3/RB Test_testtestvob.txt@@/main/CHECKEDOUT' didn't apply cleanly. The temporary files have been left in 'c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7' for debugging purposes.
`patch` returned: patching file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8
Patch attempted to create file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8, which already exists.
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file c:\users\donghoan.koo\appdata\local\temp\reviewboard.x4k9c7\tmpticux8-new.rej

What is the expected output? What do you see instead?


What operating system are you using? What browser?
 - ※ OS: Window 7, Internet Explorer 8

Please provide any additional information below.
#1 raje****@gmai***** (Google Code) (Is this you? Claim this profile.) 
In localhost, Snapshot view can't access previous file. so diff result will be created to all line added. So I hope we will find other way.
#2 raje****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I modify post-review source. (clearcase.py > def diff_file )

if self.viewtype == "snapshot":
            str_post_fix = ".reviewboard_temp"
            old_temp_file = new_file + str_post_fix
            get_cmd = ["cleartool", "get", "-to",old_temp_file, old_file]
            execute(get_cmd, extra_ignore_errors=(1, 2),
                         translate_newlines=False)
                         
            diff_cmd = ["diff", "-uN", old_temp_file, new_file]
            dl = execute(diff_cmd, extra_ignore_errors=(1, 2),
                         translate_newlines=False)
            dl = dl.replace(str_post_fix,'')
david
#3 david
  • +Component-SCMTools
    +Component-RBTools
#4 Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I think it is already fixed by http://reviews.reviewboard.org/r/3322/ could you please confirm?
david
#5 david 
In that case I'm going to assume that it's fixed and we can reopen it if necessary.
  • +Fixed