2614: Incorrect function name is displayed as location of line.

habib******@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 31, 2014 
What version are you running?
1.6.6

What's the URL of the page containing the problem?
http://codereview/r/6058/diff/#index_header

What steps will reproduce the problem?
1.Create a new review request having multiple new files (added with this review to svn)
2.Finish reviews adding comments into multiple files and to multiple functions.
3.Check the review result page (http://codereview/r/6058/), that contains incorrect function names above the review comments.

What is the expected output? What do you see instead?
If a review comment is placed for a line in SecondFunction(), I wish to see the correct function name above to comment.

What operating system are you using? What browser?
Firefox newest, Win7

Please provide any additional information below.
The review request was complicated added several new files and lots of new functions. Some names are correct.
chipx86
#1 chipx86 
The mechanism we use to determine the function name is the same one that GNU Diff uses. It's a heuristic that tries to match something that looks like a function, but it doesn't necessarily know for sure which is the nearest function. Without deeper code analysis functionality for each language, we can't know for certain. So sometimes errors crop up, but they're beyond our control.

In this case, without seeing the diff and the files, there's not much I'd even be able to look at to address this. I don't suppose you could provide some repro case.
  • +Component-DiffViewer
david
#2 david 
Without specific repro cases we can't improve the regular expressions we use.
  • +Incomplete