2595: Reviewboard doesn't show a correct error message on large diffs

voi****@gmai***** (Google Code) (Is this you? Claim this profile.)
May 28, 2012
What version are you running?
Reviewboard 1.6.6, mercurial 2.1.2, python 2.7.2

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. hg postreview revision --parent parent_revision # large diff, larger than max_size
2.
3.

What is the expected output? What do you see instead?
I expect:

abort: The specified diff file is too large (220)
stat: fail
reason: The supplied diff file is too large

I see:
abort: HTTP Error 400: BAD REQUEST

But running the code in debugger I can see that the response itself contains {"stat": "fail", "err": {"msg": "The specified diff file is too large", "code": 220}, "reason": "The supplied diff file is too large", "max_size": 1048576}. I can't understand why it stopped showing the correct error message

Please provide any additional information below.

It seems the problem is not reproducible on the same repo and with the same params on different machine. The only difference is versions of mercurial(1.9.2) and python(2.6.1)
david
#1 david
You'll have to file this against whoever maintains hg postreview. It's not something which is part of reviewboard itself.
  • +ThirdParty