2579: djblets: embedded jquery stuff doesn't incude source and copyright information

dmitry.n*********@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Jan. 19, 2014 
Hi,

I'm trying to package reviewboard together with dependencies to debian and it was noticed by Jakub Wilk that there are a few issues with JQuery .js files distributed in djblets and reviewboard tarballs

DJblets:

1. djblets/media/js/jquery-1.3.2.min.js is distributed as "obfuscated" file. Could you please put original "source" JS (human-readable) file somewhere in tarball? It's even not required to actually use it. This will simplify packaging work

2. For jquery-ui-1.6rc2.min.js and jquery-ui-1.6rc5.min.js are "obfuscated" too. JQuery UI is originally distributed under GPL/MIT and both license requirements are not satisfied (no copyright statement, etc). At the same time it looks like they are not used at all in djblets. So probably it's ok to just remove them for tarball

3. datagrid.js and jquery.gravy.js looks like not from JQuery. datagrid looks like reviewboard-specific and jquery.gravy is present in some other projects. Do you know license of these files? If they are from reviewboard, could you please specify their license at the top

Reviewboard:

1. Exactly same as p.2 for djblets: /reviewboard/htdocs/media/rb/js/jquery-tui-1.6rc5.min.js lacks copyright statement so it violates both GPL and MIT. Could you please also include it's "source" in tarball?

2. ui.autocomplete.min.js contains "original" source (thanks for this). But unfortunately it lacks copyright header too.

Thanks a lot
chipx86
#1 chipx86 
We'll try to clarify this for the next release.
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.6.x
    +Component-Deployment
  • +chipx86
chipx86
#2 chipx86 
So a few things:

1) I'm not going to be bundling the non-obfuscated version. I can put it in the Git repository, but have no desire to increase the size of our packages for something that will never be used directly. Can you describe to me why this is necessary? Can you just include it in your packages?

2) The 1.6rc2 version can go (we kept it around for backwards-compatibility reasons), but the 1.6rc5 version is being used. These are the files as provided by the jQuery-UI project, but I'll add a copyright.

3) datagrid.js and jquery.gravy.js are part of Djblets, so they retain the original copyright of Djblets.

For the upcoming releases, I'll add copyright headers to the jquery-ui files. I need more of a discussion on the rest. Especially the need to grow our packages and increase download time by bundling unused source copies.
david
#3 david 
This is fixed now. Djblets doesn't bundle any third-party modules (it references CDNs by default), and Review Board ships the sources in reviewboard/static/
  • -Confirmed
    +Fixed