256: Add/Delete/Edit/integrate information not shown for binary files.

mail*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86 
Have binary files in the changelist.
Create a diff using p5 diff -du & upload the diff manually to create the 
review.
The reviewboard displays: "This is a binary file. The content cannot be 
displayed." without the type of perforce change.
chipx86
#1 chipx86 
This is more of an enhancement than a bug, I'd argue. There's not always much info we
can get for binary files. I'll look into adding this.
  • -Type-Defect
    +Type-Enhancement
    +Component-DiffViewer
  • +chipx86
chipx86
#2 chipx86
  • +Milestone-Release2.0
#3 motto.e*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'd really like to see this, too. It's a major pain to remove e.g. image files from
the changeset before being able to put it into reviewboard.
#4 s**@mit**** (Google Code) (Is this you? Claim this profile.) 
I'd also like to see this.

While the general case may be difficult to display properly (though one could imagine
something involving xxd followed by diff, or allowing special filters based on
filetype the way that CUPS might interpret PDF files differently than PS files), it
should be possible to handle additions and deletions more intelligently.  For
example, a p4 deletion can easily be displayed as "file deleted" in the web UI and
encoded in the diff correctly, regardless of file type.
david
#5 david
  • +Confirmed
#6 steve.a********@gmai***** (Google Code) (Is this you? Claim this profile.) 
We're using 1.0.8 with a subversion database, and a post-commit workflow. Uploading a diff with an image delete, image add, and image modify (3 different files) only shows "binary file" for each one, so the reviewer can't tell which of the three files is the one being deleted.

If you could show the before and after images, great, but if not, showing if it's an add/delete/modify would help alot.
#7 willia******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'd prefer an option to not show the binary files at all or summarize them separately from the readable code changes.
#8 shiv****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I think it should at least convey that the file has been deleted. Can be misleading at times.
david
#9 david
  • -Milestone-Release2.0