2553: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

smacleod
Oct. 25, 2012 
What version are you running?
1.6.4+ (Probably earlier as well)

What's the URL of the page containing the problem?
/api/review-requests/{review-request-id}/diffs/{diff-id}/files/{file-id}/ where at least one of the id numbers is invalid.

What steps will reproduce the problem?
1.Visit the URL

What is the expected output? What do you see instead?
This should return the 404 page with the error payload. Instead, a 404 with an empty response body is returned.

What operating system are you using? What browser?
Ubuntu 11.10, Chrome 18

Please provide any additional information below.
mconley
#1 mconley
  • +EasyFix
#3 miche.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Will look into this. - Michelle C.
#4 miche.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
The page does actually return with an error payload, but it doesn't seem to show up with certain plugins like Firebug or Chrome REST Console.
#5 smacleod 
As mentioned previously, this is not a bug, but merely the result of browsers hiding the payload.
  • +UserError
  • -Priority-Medium
    -EasyFix