2527: Incorrect error when uploading diff and not being able to connect to GitHub repository

marian*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 24, 2012 
What version are you running?
1.6.3

What's the URL of the page containing the problem?
http://reviewboard_url/r/new/

What steps will reproduce the problem?
1. Configure a repository with an invalida GitHub repository (in my case, I missed the "private organization" option and used "private" when I really ment "private organization". API token was OK, repo owner and repo name were OK also) 
2. Try to upload a diff for that repo


What is the expected output? What do you see instead?
Review request should be created/updated

Instead, you get a message like "The file "xxxx.file" (revision 24ad159c31b8719a096fc469fbc904c6cae5b50c) was not found in the repository"

The problem is not that the file not exists, but that the repo config is wrong (pointing to a non-existent repo, or even to an existent repo but with bad API Token/user)
#1 smbs*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I think the path should be where the diff is.
#3 marian*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Sorry, but I don't get what you are saying. What do you mean by the path should be where the diff is?
#4 smbs*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Sorry,I was wrong.
I also met this problem,and it seems strange.
I have deployed reviewboard both on my notebook and pc,but the situation is different.
On pc,it suggests "error 500" when trying to upload a diff file,whatever the base directory is.
However,on notebook,when I set the Base Directory like "file:///E:/***",I succeed in uploading the diff. I tried to set base directory like "http://localhost/***",it suggests the file can't be found in the repository.But I can visit the repository via
both url(http or file).   
I used subversion and apache.
Because of some reason,I can't attach the log file now.
#5 marian*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I get it now. However, I think you should open a new Issue, as the problem doesn't seem to be related. In your case, the error is "wrong" but nos "missleading", as it doesn't suggest that you can't upload the file because of a reason that is not the right one (in my case, it says that the file is not found in the repository when it should say that he couldn't even reach the repo)
david
#6 david 
I believe the new hosting services implementations should address this (since it does a better job at verifying when creating new repositories).
  • +Fixed