2512: Modify review fields persmissions

yakov.she*********@gmai***** (Google Code) (Is this you? Claim this profile.)
March 2, 2012
http://reviews.reviewboard.org/


What version are you running?

1.6.1

What's the URL of the page this enhancement relates to, if any?

review page

Describe the enhancement and the motivation for it.

Not an enhancement reallly6 but question: is there any option to allow certain people (not only admins or review submitter) change review fields, "People:" for example? I try to give different permissions to user, from "reviews | review " permissions group, but with no effect.
david
#1 david
There's no fine-grained access control at the moment. We're discussing how to improve collaboration between multiple people on a single review request for a future release, but it probably won't be soon.

If you'd like to ask questions, the mailing list(s) are a much better place than here.
  • +NotABug
#2 yakov.she*********@gmai***** (Google Code) (Is this you? Claim this profile.)
ok, thanks
i asked this question in mailing list (reviewboard@googlegroups.com), but with no answers.

also, i cant find anywhere in docs description of current permissions - what permissions used for in current RB versions?
david
#3 david
There's not much. The permissions you see in the admin UI are built-in to django, and we don't really make use of them at all. If you give a user staff permissions they'll be able to make changes to other people's review requests.
#4 yakov.she*********@gmai***** (Google Code) (Is this you? Claim this profile.)
unfortunately, giving user Stuff status will allow him not only modify reviews, but also makes visible to him Admin page. And this is not good and not always acceptable.
david
#5 david
Yes, we know. As I said, we're working on figuring out how to address this problem in the future.
#6 yakov.she*********@gmai***** (Google Code) (Is this you? Claim this profile.)
i'm sorry continuing duscussion in closing issue, but - i give user a staff status, but he still cant modify fields in review, cant change reviewers list ("People:" field, for example) in existing reviews. Is this a bug or am i wrong somehow?
david
#7 david
I'm sorry, I meant the admin role.