2500: Email notifications have no From field in 1.6.4

roy.jean*********@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Aug. 12, 2013 
What version are you running?
1.6.4

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Configure email notifications.
2. Post a review request with post-review using the --submit-as option.

What is the expected output? What do you see instead?
Email notifications should have the From field set to the submit-as user, or at least the "from" email configuration. Instead, emails have no From fields.

What operating system are you using? What browser?
OS X 10.7, Windows 7. Safari 5.1, Chrome 19.

Please provide any additional information below.
This is a regression from 1.6.3 to 1.6.4.
#1 roy.jean*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
RBTools was 0.3.4 at the time. I haven't tried  with 0.4 yet (it doesn't seem to be on Pypi yet).
#2 roy.jean*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Still repros with RBTools 0.4.
chipx86
#3 chipx86 
RBTools doesn't really factor into this. It's a Review Board issue.

Do you get e-mails with a From field when other users post?

What is your default e-mail From: address setting in Review Board -> Settings -> E-mail?
  • +NeedInfo
  • +Component-EMail
    +Milestone-Release1.6.x
#4 roy.jean*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Emails sent as a result of someone posting a comment on a review request do have a From field.

The Sender email address setting is of the form aaa-bbb@sub.example.com.
#5 tchris******@bykd**** (Google Code) (Is this you? Claim this profile.) 
I thought I was experiencing this issue, but it was actually issue 1795.

After setting the email address for the user that was used for automatic submission of diffs, everything is fine.  This was working before, though, with the same configuration.
#6 gogo****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I think I have the same problem in 1.6.9,
From field is empty.

It was working fine in 1.6.3
#7 rvel****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I have the same problem, just updated to 1.6.9, from field is gone from emails, but submitter of reviews is correct, it's just the from field..
#8 wa***@meetu***** (Google Code) (Is this you? Claim this profile.) 
We recently upgraded to 1.7.7.1 and are seeing this issue as well
david
#9 david
  • -NeedInfo
    +Started
  • +david
david
#10 david 
Fixed in release-1.7.x (8cc0f4d). Thanks!
  • -Started
    +Fixed