247: Error submitting changelist with purely binary file changes

mail*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Dec. 26, 2007 
post-review.py <changelist number>
Traceback (most recent call last):
  File "c:\python24\post-review.py", line 452, in ?
    main()
  File "c:\python24\post-review.py", line 448, in main
    tempt_fate(changenum, repository_path, client_root)
  File "c:\python24\post-review.py", line 390, in tempt_fate
    upload_diff(review_request, changenum)
  File "c:\python24\post-review.py", line 366, in upload_diff
    diff_content = generate_diff(changenum)
  File "c:\python24\post-review.py", line 346, in generate_diff
    m = re.search(r'(\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d)', dl[1])
IndexError: list index out of range
chipx86
#1 chipx86 
Can you e-mail me privately the result of:

post-review --debug <changelist number>
  • +NeedInfo
  • +Component-Scripts
  • +chipx86
#2 mail*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Sorry, already submitted changelist. I added an text change to the changelist as
well, and it still kept throwing errors. Suspect that the presence of a binary file
throws this error.
chipx86
#3 chipx86 
Can you create a new one with a dummy binary file similar to your existing changeset?
#4 laur*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
FYI, I got the same error with my change list 552571 which included 2 .jar files
among other things.  Once I removed the .jar files it worked
chipx86
#5 chipx86
  • -NeedInfo
    +Accepted
  • +Milestone-Release1.0
david
#6 david 
Christian, do you have a copy of a diff that causes this?  I want to figure out why
the "Binary files" check fails.
david
#7 david 
Should be fixed in SVN.  Thanks.
  • -Accepted
    +Fixed