What's the URL of the page containing the problem?
This happens when I use the post-review script. I think the JSON URL that
is used is something like the following:
/api/json/reviewrequests/1/diff/new/
I believe the '1' is just the review request ID, so it could be an
arbitrary number.
What steps will reproduce the problem?
1. Submit a diff using post-review with a Subversion repository on Windows
(with Subversion and Review Board also hosted on Windows).
What is the expected output? What do you see instead?
The excepted output seems to be something like the following (at least this
is what I get after applying the attached patch):
Error uploading diff: The file was not found in the repository (207)
Your review request still exists, but the diff is not attached.
However, instead of this, I get the HTML of a Django server error page
printed to the console. The error page says that there was an
AttributeError raised while trying to access the 'filename' attribute of a
'FileNotFoundError' object. This is on line 998 of
'/trunk/reviewboard/reviews/json.py'.
What operating system are you using? What browser?
Windows XP SP2 with Firefox 2.0.0.7.
Review Board is run on the same box. The repository being used is
Subversion 1.4.5 with a FSFS backend (also on the same machine and accessed
with 'file:' type paths).
Please provide any additional information below.
The problem just seems to be a typo. In particular, FileNotFoundError has
a 'path' attribute rather than a 'filename' attribute.
I've attached a patch file that seems to fix the problem. It should be
applied to the reviewboard directory in the trunk. The base revision when
I created the patch was 958.
