2425: post-review -review-request-id doesn't appear to work for SVN

elsq****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 15, 2011
2286
What version are you running?
RBTools 0.3.4

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Create a review
2. Try to update the review with a command like:
post-review /path1/foo.c --server=http://rb.example.com --repository-url=https://svn.example.com/svn/ --revision-range=103731:103732 --review-request-id=21 

What is the expected output? What do you see instead?

Expect to see the foo.c diff added to the review.  Instead:

>>> repository info: Path: https://svn.example.com/svn, Base path: /path1/foo.c, Supports changesets: False
>>> Uploading diff, size: 446
>>> HTTP POSTing to http://rb.example.com/api/review-requests/21/diffs/: {'basedir': '/path1/foo.c'}
>>> Got API Error 207 (HTTP code 400): The file was not found in the repository
>>> Error data: {u'stat': u'fail', u'file': u'/path1/foo.c/foo.c', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'103731'}

Note that "foo.c" is duplicated in the path.

What operating system are you using? What browser?
Win7 32-bit


Please provide any additional information below.
david
#1 david
Mixing --revision-range and file paths doesn't work with svn.
#2 elsq****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'm not sure this is a duplicate of 2286.  In that bug, it is hanging on creating the diff.  In my case, the diff command completes, but it gets the error shown above (API Error 207) when trying to upload the diff.

The generated diff is fine (I can copy the svn diff command from the post-review debug output and run it on the command line and get a valid diff).  So I don't think this is an SVN problem, but a problem with the post-review script.