2405: review board cant show patches if HEAD is modified

kofe****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 8, 2012 
What version are you running?
1.6.3

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. submit a review request
2. commit a change head that conflicting with the patch
3. view diff

What is the expected output? What do you see instead?
diff

What operating system are you using? What browser?
error from patch command

Please provide any additional information below.
This happens with at least mercurial. As I remember, rb have to parse diff header and apply patch against submitted version. This is not the case any more (since 1.6.0? ).
david
#1 david 
This should definitely not happen. Can you clarify exactly what your repository set up is? (SCM, method of access, versions of everything)
  • +NeedInfo
david
#2 david
  • -NeedInfo
    +Incomplete
#3 kofe****@gmai***** (Google Code) (Is this you? Claim this profile.) 
My apologies for delay.

I use repository with mercurial.

I have looked with tcpdump and here is the result:
if patches are produced with --git option, then there are no version information included into diff:

diff --git a/file1 b/file1

without --git option version numbers are included:
diff -r 5c8aa63c3bbd -r 54de8eca7162 file1

probably this is the source of the problem.
Now question is should review board pic and store current HEAD or
postreview script which I use.

Thanks,
-k
david
#4 david 
post-review will fix this for you.
#5 kofe****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I believe I fixed it in mercurial-reviewboard extension.
Anyway, you can close this ticket.

-k.