238: Need to move from virtual line numbers to real line numbers in diffs.

grossag
Sept. 30, 2007
This is more of an opinion than a bug, but I think that listing line
numbers for deleted lines is confusing.  I personally like to look at a
diff, see a line number, go to the source file on my machine, browse to
that specific line number, and make a change.  But the way that reviewboard
is set up right now, the line numbers do not correspond to the line of the
source code file.  But if you were to skip line numbers on deleted lines,
I'm pretty sure it would work the way I want it to.
chipx86
#1 chipx86
Line numbers are virtual right now. We're going to be moving to real line numbers
fairly soon I think. I thought there was another bug about this, but I guess not, so
I'm making this one a bit more general.
  • -Type-Defect
    +Type-Task
    +Component-DiffViewer
  • +Need to move from virtual line numbers to real line numbers in diffs.
chipx86
#2 chipx86
  • +Fixed