2366: review request plain email template: diff url broken

henr*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 4, 2011 
What version are you running?
1.6.1

What steps will reproduce the problem?
1. Create a review request and attach a diff.
2. Use a email program that reads plain text by default (not html) 
and check review request notification e-mail
diff link in e-mail is broken

What is the expected output? What do you see instead?
I expect the same link as in the html email notification.

Please provide any additional information below.
diff to the e-mail template in my internal installation which fixes problem.
remove_extra_diff_in_template.patch 
--- reviewboard/templates/notifications/review_request_email.txt.orig	2011-11-02 18:43:24.308438836 -0700
+++ reviewboard/templates/notifications/review_request_email.txt	2011-11-02 18:43:45.968439087 -0700
@@ -41,7 +41,7 @@ Diffs{% if changes and changes.diff %} (
 {% for filediff in review_request.diffset_history.diffsets.latest.files.all %}
   {{ filediff.source_file }} {{ filediff.source_revision }} {% endfor %}
 
-Diff: {{domain_method}}://{{domain}}{% url view_diff review_request.display_id %}diff
+Diff: {{domain_method}}://{{domain}}{% url view_diff review_request.display_id %}
 
 
 Testing{% if changes and changes.testing_done %} (updated){% endif %}
david
#1 david 
In general, we prefer patches to be submitted to http://reviews.reviewboard.org/

In this case, it's small enough that I'll just commit it. Thanks!
  • +Fixed