2365: Reviewboard fails to properly display code diffs

quanah.gi*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 10, 2012
What version are you running?

1.6.1

What's the URL of the page containing the problem?

(Internal URL you can't access)

What steps will reproduce the problem?
1. Modify a file
2. Submit it for review
3. View the diff as presented by reviewboard.

What is the expected output? What do you see instead?
I expect it to accurately show the changes made.  Instead, it incorrectly shows a line that already existed as an ADD, and a line that is brand new as a MOD

What operating system are you using? What browser?
Windows 7/Firefox.  Coworkers using OSX/Firefox see the same issue.

Please provide any additional information below.

I've attached a screenshot of a problematic review.

The diff in question is for "zmconfigd.cf".  It says that line 150 (on the right) is an ADD.  You can clearly tell it is not an ADD by looking at the fact it already exists on the left.  Line 145 was the actual ADD made to the file.
david
#1 david
unfortunately, in some situations like this when there are lots of similar strings, and when you've changed them (the existing line had whitespace changes), there's not much we can do. We use the same diff algorithm as many other tools.
  • +WontFix