235: Entering path manually in "Upload diff" broken
- Fixed
- Review Board
| grossag | |
 |
|
| Sept. 19, 2007 |
I clicked "Upload diff" and instead of hitting "Browse" to find the diff, I tried to manually type the path. However, if you hit any of the keys that navigate in the page (e.g. 's', '.', or ','), it performs the associated action instead of just entering the character.
This was from the diff viewer, right? We're taking away those buttons on the diff viewer so as to remove problems like this.
-
+ chipx86
Yes it was. But I use the navigational commands a lot and also wish "Shift + ," and "Shift + ." were supported. You aren't taking away all of the navigational commands right?
Okay, going to mark this as fixed then. No, we're not intentionally taking anything away. It's just we're listening for an onclick event and redirecting the site, but that doesn't take into account browser-specific keybindings, so we have to specifically support them. The shift-stuff will be supported soon. I have a fix in the works.
-
+ Fixed