2340: Reviewboard posts wrong Diff URL in notification emails

Goli*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 4, 2011 
What version are you running?

1.6.1


What's the URL of the page containing the problem?

http://mail.kde.org/pipermail/kde-utils-devel/2011-October/000668.html


What steps will reproduce the problem?
1. Make sure, email notification for review requests is enabled
2. Create Review Request

What is the expected output? What do you see instead?

Reviewboard sends an Email to the configured address containing an url to a diff view. This URL reads:

http://git.reviewboard.kde.org/r/102785/diff/diff

which gives a 404 error. The URL should read 

http://git.reviewboard.kde.org/r/102785/diff

instead.
chipx86
#1 chipx86 
Hmm, we haven't noticed this in our deployments. We use Django to tell us the location of the diff, which should always be a valid path. Do you have any customizations of templates anywhere?
  • +NeedInfo
#2 Goli*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
not that I know of. maybe years old, but those wouldn't survive an update right? how would I check? which path would I need to compare to an unmodified release?
david
#3 david 
This is actually a real bug, but it only shows up in the plain text part of the email. There's a fix for this in issue 2366 which I'll be committing today.
  • -NeedInfo
    +New
david
#4 david 
Fixed in release-1.6.x (0d1c6e8)
  • -New
    +Fixed
#5 Goli*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
great. thanks a lot!