2332: Diff is not available intermittently

katsn*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 10, 2012
2331 
What version are you running? 1.6.1


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
see the diff                   error below

What operating system are you using? What browser?


Please provide any additional information below.

Diff currently unavailable.
Error: The patch to 'http://svn.sj.broadcom.com/svn/wlansvn/proj/trunk/src/tools/mfgc/src/base_tests/hostAspmSettings.cc' didn't apply cleanly. The temporary files have been left in 'c:\temp\reviewboard.gae-a5' for debugging purposes. `patch` returned: patch: **** Can't create file C:\Temp/ppz03180 : File exists
Details

Traceback (most recent call last):
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\views.py", line 217, in view_diff_fragment
    file = get_requested_diff_file()
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\views.py", line 193, in get_requested_diff_file
    get_chunks)
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1071, in get_diff_files
    large_data=True)
  File "c:\python25\lib\site-packages\Djblets-0.6.11-py2.5.egg\djblets\util\misc.py", line 155, in cache_memoize
    data = lookup_callable()
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1070, in <lambda>
    enable_syntax_highlighting)),
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 552, in get_chunks
    new = get_patched_file(old, filediff)
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 374, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File "c:\python25\lib\site-packages\ReviewBoard-1.6.1-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 242, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'http://svn.sj.broadcom.com/svn/wlansvn/proj/trunk/src/tools/mfgc/src/base_tests/hostAspmSettings.cc' didn't apply cleanly. The temporary files have been left in 'c:\temp\reviewboard.gae-a5' for debugging purposes.
`patch` returned: patch: **** Can't create file C:\Temp/ppz03180 : File exists
#1 katsn*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The issue is very annoying. It occurs intermittently. Refreshing the page sometimes resolves it.
#2 katsn*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The issue is very annoying. It occurs intermittently. Refreshing the page sometimes resolves it.
chipx86
#3 chipx86 
Are you an admin there? If not, you may need to contact your admin and have them help figure it out, or work with us on it.
  • +NeedInfo
  • -Type-Defect
    +Type-Support
#4 h130*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Hello, I have admin access on the ReviewBoard server. I see the same issue OP has mentioned. Any suggestions will be greatly appreciated. 

Thanks.
chipx86
#5 chipx86 
The paths are confusing me. They look to be built with a mix of Windows and Unix line endings. That may be a red herring, given that the original message is that the patch didn't apply cleanly, but still, something to wonder about...

Can you find the directory it's talking about and see what the .rej file looks like?

It's possible you're hitting some weirdness with mixed line endings.

Are you using post-review to generate the diff, or something else?

What are you using for server-side caching? Memcached, or file-based caching?
chipx86
#6 chipx86
#7 katsn*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Great, thank you.
Sorry, we'll answer your questions a bit later.
#8 h130*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Hello, 

I tried looking inside the above directories and was not able a .rej file. Only the diff files associated with the review. Which directory are you specifically looking at?

I generate diffs through subversion by command line ("svn diff > <filename.txt>"), not through post-review. OP may be using post-review, can you comment?

For server side caching we are using Memcached. 

Thanks.
#9 h130*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Hello, 

I tried looking inside the above directories and was not able a .rej file. Only the diff files associated with the review. Which directory are you specifically looking at?

I generate diffs through subversion by command line ("svn diff > <filename.txt>"), not through post-review. OP may be using post-review, can you comment?

For server side caching we are using Memcached. 

Thanks.
david
#10 david 
Perhaps the source file that it's trying to patch can shed some light? Maybe it's some kind of error page?
david
#11 david
  • -NeedInfo
    +Incomplete