233: Don't require loggin in to reviewboard
- WontFix
- Review Board
bhaves*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
Sept. 19, 2007 |
What's the URL of the page containing the problem? http://reviewboard.eng.vmware.com What steps will reproduce the problem? 1. Follow a ReviewBoard generated review request URL 2. 3. What is the expected output? What do you see instead? ReviewBoard insists that the user log in before s/he can see posted review comments, or post new comments. I would think ReviewBoard should be able to figure out who the user is based on environment variables, and go with that. Yes, I agree it is slightly less secure, but I don't think you need to be any more secure. What operating system are you using? What browser? Doesn't matter. Please provide any additional information below. Folks who've been resisting using ReviewBoard cite this as one of the main annoyances of responding to review requests.
RB doesn't force you to log in just to look at a change. As far as posting comments, you have to be logged in. What do you mean "environment variables"?
Like $USER on Unixen and %USERNAME% on Windows, just to provide a hint on who's posting the review comments. I have no idea if you have access to those variables from within the browser, though. Even if you could get rid of the requirement to be logged into ReviewBoard to view someone else's comments on a review request, that would be a big plus.
Review Board is a web app. It doesn't have access to such environment variables. They're never sent by the browser, so there's nothing we can do here. It's just a requirement of web apps. Review Board is also not VMware-specific, which means it needs to work in environments that aren't as uniform as ours. This means logins are required. If your browser is configured correctly, though, you should only have to log in once (though on occasion, upgrades make everyone log in again).
-
+ WontFix