2264: Updating a diff when not owner causes problems

Carl.va*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 24, 2012
2180
2487
What version are you running?
1.6 RC2

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Create a review 1234 (submitter: john)
2. Different user (peter) clicks "Update Diff" on 1234
3. Upload a file

What is the expected output? What do you see instead?

Expected: Diff is updated, or error "not submitter" is produced

Instead: Goes straight back to the review without completing the diff-add (i.e. the stage of adding info about the changes)
A pending-review-request is left lying around in the database, which needs to be manually removed via Admin interface.
Submitter has to be changed via Admin interface before peter can upload the review.
On older reviewboards, this may corrupt the database, but seems not to on 1.6.

What operating system are you using? What browser?
Linux host, Windows+chrome client

Please provide any additional information below.

peter has admin rights. I don't know if this is part of the issue.
david
#2 david
I think this is similar enough to 2180 to merge.