2262: Update diff by nonsubmitter not working

bas****@bran***** (Google Code) (Is this you? Claim this profile.)
Aug. 29, 2011
What version are you running?
1.5.5

What's the URL of the page containing the problem?
/r/*

What steps will reproduce the problem?
1. Prepare two users test1 und test2. Give user test2 all user permissions via the admin.
2. Prepare two test patches.
3. Login as test1 
4. Publish a review request including a patch using user1.
5. Login as test2
6. Click update diff in the review request created in step 1 and upload the second patch.

What is the expected output? What do you see instead?
I expect the green box at the top with 'This review request is a draft: ...' in the title. But nothing happens on the user interface. Something must have happened. Because if I edit the description of the review request. The green box appears. After publishing the new description the diff has changed as well. 

What operating system are you using? What browser?
OSX 10.5.8, Chrome 13.0.782.215 

Please provide any additional information below.
chipx86
#1 chipx86
Technically, the ability to impersonate another user and edit their review request is more of a debug/maintenance thing. We don't actually support scenarios yet where multiple users can modify one review request. Though, I've been considering ways of making that officially supported in a future release.

As for now, though, it's not actually a bug.
  • +NotABug