2259: Replying to a comment on a review breaks the js popup on IE8
- Fixed
- Review Board
| yosh*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Nov. 4, 2011 |
What version are you running? RBTools-0.3.2.dev_20110607 ReviewBoard-1.6rc2 What's the URL of the page containing the problem? http://codereview.acmepacket.com/r/339/# What steps will reproduce the problem? 1. A reviewer adds a comment during a review. 2. The originator uses "add comment" within the previous comment box, to add a reply. What is the expected output? What do you see instead? Should see a green "publish" popup so that the new comment can be committed to the database. But the circular 'updater icon' just spins, the green "publish" popup never appears at the top of the page, so the comment can't be published. What operating system are you using? What browser? WinXP with IE 8 Please provide any additional information below. Problem doesnt occur for firefox or chrome. Output from IE8 error dialog is: Webpage error details User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 1.1.4322; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E; InfoPath.3) Timestamp: Fri, 26 Aug 2011 13:44:10 UTC Message: Invalid argument. Line: 12 Char: 12949 Code: 0 URI: http://codereview.acmepacket.com/media/djblets/js/jquery-1.3.2.min.js
Is there any work around for this? Many of the people on our team use IE and it appears to be an issue for them.
I don't know off-hand. I'd need more information about what's being called and how it's breaking. Something to look at for 1.6.2.
-
+ Confirmed -
- Priority-Medium + Priority-Critical + Milestone-Release1.6.x + Browser + OpSys-Windows + Component-Reviews
I can readily reproduce this issue so if you need more information please let me know what I can get for you.
Here's a workaround, to change the floating review box into a fixed box on IE.
--- ./reviewboard/htdocs/media/rb/js/reviews.js.orig 2011-10-14 14:57:17.000000000 -0400
+++ ./reviewboard/htdocs/media/rb/js/reviews.js 2011-10-14 15:05:48.000000000 -0400
@@ -832,6 +832,11 @@
return;
}
+ /* floating fails on IE */
+ if ($.browser.msie) {
+ return;
+ }
+
if (floatSpacer == null) {
floatSpacer = self.wrap($("<div/>")).parent();
updateSize();
My users report that this fixes the IE issue for them, which occurs in the 1.6.1 as well.
