222: Expand does not work under safari 2.0.4 (419.3) in OS X 10.4.10

fro****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 9, 2008
What steps will reproduce the problem?
1. Open a review in safari 
2. Click on expand.

What is the expected output? What do you see instead?
Insead of viewing th expanded part of the file, you jump to top of page

What operating system are you using? What browser?
OS X 10.4.10 patch up as of 20070830 running safari 2.0.4 (419.3)

Please provide any additional information below.

When I open up the diff (in my case:
http://reviewboard.eng.vmware.com/r/2600/diff/#index_header)
I get:

===== Thursday, August 30, 2007 12:35:32 PM US/Pacific =====
[14278] http://reviewboard.eng.vmware.com/scripts/diffviewer.js:SyntaxError - Parse error
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId
[14278] http://reviewboard.eng.vmware.com/r/2600/diff/#index_header:ReferenceError - Can't 
find variable: gFileAnchorToId

furthermore the expand link gives me:

===== Thursday, August 30, 2007 12:37:03 PM US/Pacific =====
(event handler):Object  (result of expression expandChunk) does not allow calls.
(event handler):Object  (result of expression expandChunk) does not allow calls.
david
#1 david
  • +Component-DiffViewer
    +Browser
chipx86
#2 chipx86
Does it work these days? How about with newer Safaris?
  • +NeedInfo
#3 fro****@gmai***** (Google Code) (Is this you? Claim this profile.)
Looks like it's working under Leopard 10.5.1/Safari 3.0.4 (5523.10.6).
Thanks!
chipx86
#4 chipx86
Good enough for me. Thanks!
  • -NeedInfo
    +Fixed