What version are you running?
1.6 RC1.
What's the URL of the page containing the problem?
/r/1/diff
What steps will reproduce the problem?
1. Create a review request. don't load it.
2. Take SVN server offline
3. Load review request and look at diffs in the browser.
What is the expected output? What do you see instead?
exp: proper error handling
act: error on error handler: global name 'ClientError' is not defined
What operating system are you using? What browser?
Server 2003, Chrome (latest)
Please provide any additional information below.
global name 'ClientError' is not defined
Traceback (most recent call last):
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\views.py",
line 151, in view_diff
interdiffset, highlighting, True)
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 1071, in get_diff_files
large_data=True)
File "c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py",
line 166, in cache_memoize
data = lookup_callable()
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 1070, in <lambda>
enable_syntax_highlighting)),
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 551, in get_chunks
old = get_original_file(filediff)
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 364, in get_original_file
large_data=True)[0]
File "c:\python25\lib\site-packages\Djblets-0.6.8-py2.5.egg\djblets\util\misc.py",
line 166, in cache_memoize
data = lookup_callable()
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 363, in <lambda>
data = cache_memoize(key, lambda: [fetch_file(file, revision)],
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 342, in fetch_file
data = tool.get_file(file, revision)
File "c:\python25\lib\site-packages\ReviewBoard-1.6rc1-py2.5.egg\reviewboard\scmtools\svn.py",
line 135, in get_file
except ClientError, e:
NameError: global name 'ClientError' is not defined
