2180: Allow ownership of review requests to be claimed

stefan.lo*********@gmai***** (Google Code) (Is this you? Claim this profile.)
2264, 3615, 3664 
http://reviews.reviewboard.org/


What version are you running?
1.6 RC1

What's the URL of the page this enhancement relates to, if any?
N/A

Describe the enhancement and the motivation for it.
Allow the Submitter field to be changed for a bug. In a workflow where ownership for a code review might change around, it would be helpful for someone with admin rights to re-assign a code review.

What operating system are you using? What browser?
Ubutu Server 10.04, Chrome.

Please provide any additional information below.
chipx86
#1 chipx86 
I've been thinking about ways to make review requests more collaborative, and have a couple small ideas. I'm not entirely sure yet about reassigning submitters, but I'll brainstorm some ideas around this. I'm thinking another developer could "claim" a review request and have it basically spawn a new one, essentially forking it and pointing back to the old one. There's a track record this way and ownership (which is a tricky thing to reassign cleanly) won't have to change.

Repurposing this bug.
  • +Confirmed
  • +Milestone-Release1.7
    +Component-Reviews
  • +Allow ownership of review requests to be claimed
#2 stefan.lo*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Sounds good.

Just to give you some additional context: the development team that I'm working on is implementing a code review workflow the includes performing random sampling of Subversion commits and conducting code review on them. In this case, all commits are captured as draft reviews for a "random-sampling" RB account. At the beginning of each week, a cronjob runs to select X commits, assign them developers, and publish the request. At that point, it would be nice to change the Submitter from "random-sampling" back to the original submitter who made the commit, assuming that the user names between ReviewBoard and the Subversion authentication are the same.
david
#3 david 
Crystal is working on this but I think we should push it into the next release, since it's a pretty big change.
  • -Milestone-Release1.7
    +Milestone-Release1.8
david
#4 david
#5 peter.kje*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
What is the status of this?

At the company I work for, being able to change the owner of a review is probably the most asked for feature in RB. It is not uncommon here that a member of a development team creates a number of reviews that run for a while, and then suddenly that user is not available for a while (long time illness, vacation, etc) and the reviews either need to be manually recreated or delayed, neither of them being good options. 

What we would like is the option to change the owner to another team member, either by the original owner, e.g., in preparation for vacation, or by an administrator, e.g., due to illness.

Even better would be to be able to have multiple owners, as sometimes this more closely resembles the actual work organization, as there may be multiple users working on solving the review comments for one review.
david
#6 david 
We've continued to think about this every so often, but still don't have a great solution. No matter what we do, it's going to be a big task. Our priorities right now are on other things, but we'll probably swing back around to this after we push out the next major release.
david
#7 david
  • -Milestone-Release1.8
david
#8 david
david
#9 david
david
#10 david
#11 tdr****@gmai***** (Google Code) (Is this you? Claim this profile.) 
It worked before, from the admin page, if you change the submitter.

It's cumbersome, but if you have some code which was handed to you by your colleague who left for vacation, you had a way to continue the review conversation.

Now it started failing with issue-3801, which is marked as duplicate.
But I don't think it is.

Yes, you don't have a GOOD way to make this work, but at least fix the only way we had to do that before.
#12 attila*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
My workaround for my issue (3801) is giving a commit ID.
#13 tdr****@gmai***** (Google Code) (Is this you? Claim this profile.) 
How can i give the commit id?
#14 attila*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
It is on the admin page. See issue 3801 to see how to get to there, and from there it is obvious, there is a field called "commit ID", and give a value to it. Unfortunately if you are not the admin, you will have to ask your RB key user.
david
#15 david 
This was addressed in 3.0 (https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0/#reassign-review-request-ownership)
  • -Confirmed
    +Fixed