jameslin

217: Should Reviewboard really use target="_blank" for the Bug/Report Bug links?

jameslin
chipx86
 chipx86
Aug. 29, 2007 
The "Bug" and "Report Bug" links at the top of reviewboard pages currently
open new browser windows.  IMO this is annoying.  Modern web browsers
provide the ability to explicitly open specific links in new windows (or
tabs) via context menus, middle-clicking, modifier-key+clicking, whatever.
If I want a new window, I'll ask for it.

Why should it matter that these links go to Google Code instead of to some
other reviewboard page?
chipx86
#1 chipx86 
The idea was that if there was an error on the screen, we'd want to make sure that
the user still had a chance of seeing it while the bug report was open, instead of
just clicking the link and then realizing part-way through that they have to click
back (losing the bug report and possibly the error message).
jameslin
#2 jameslin 
Do you think that people filing bugs wouldn't know to do that already?  Besides, you
have to scroll all the way to the top of the page to get to those links.  I find it
easier to open a new tab, go to reviewboard, and click on "Report bug", but then I
end up with three tabs...
chipx86
#3 chipx86 
Okay, that's a fair point.

A good compromise might be to include one of those little "Open in new window" icons
next to the link. But yeah, I can remove the target=
  • +chipx86
chipx86
#4 chipx86 
Went ahead and made the change. I'll update in a bit.
  • +Fixed