2169: The close description is editable by other users

chipx86
July 10, 2011
What version are you running?
1.6 RC2 dev

What steps will reproduce the problem?
1. View a closed review request owned by another user.

What is the expected output? What do you see instead?
The close description shouldn't be editable, and if empty, it shouldn't even be shown. Instead it is shown and is editable, or appears to be anyway.
chipx86
#1 chipx86
  • +Milestone-Release1.6
#2 hongb*****@gmai***** (Google Code) (Is this you? Claim this profile.)
The close description windows will show up if the login user pass the check: {% ifuserorperm review_request.submitter "reviews.can_change_status" %}. It looks like you tested it with a staff user so it showed up and became editable. I will looks into that to make it work better.
chipx86
#3 chipx86
Oh, you're right. I thought I didn't because the other fields weren't editable, but I wasn't thinking. They weren't because it was closed. Yeah, closing this one :)
  • +NotABug