2165: Issues with Internet Explorer
- Fixed
- Review Board
| almo****@dataw***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| July 31, 2011 |
What version are you running? 1.6rc2.dev-20110628 What's the URL of the page containing the problem? http://reviewserver/r/1308 What steps will reproduce the problem? 1. View an existing review request 2. Attempt to click any of the following buttons, [Close, Add Screenshot, Add File, Update Diff, Review, Ship It!] What is the expected output? What do you see instead? Buttons should perform expected function What operating system are you using? What browser? IE9 on Windows 7 Please provide any additional information below. Errors reported in IE Developer Tools: SCRIPT1028: Expected identifier, string or number datastore.js?1310058959, line 1021 character 13 SCRIPT5009: 'RB' is undefined reviews.js?1310058959, line 11 character 1 SCRIPT438: Object doesn't support property or method 'commentSection' 1308, line 498 character 7
IE9 is most likely running in IE7 compatibility mode, especially it the server you are accessing is considered an internal intranet server. You can disable compatibility mode in IE9. What I did to fix the problem globally was add:
<head>
+ <!-- Enable IE9 Standards mode -->
+ <meta http-equiv="X-UA-Compatible" content="IE=9" >
<title>{% block title %}{% endblock %} | Review Board</title>
To the base.html template file.
http://msdn.microsoft.com/en-us/library/cc288325(VS.85).aspx#SetMode
http://support.microsoft.com/kb/956197
Well, this fixes the issue for IE9, however, it does not for IE6. IE6 reports: Line: 1022 Char: 13 Error: Expected identifier, string or number Code: 0 URL: http://reviewserver/r/1308/ Line: 12 Char: 1 Error: 'RB' is undefined Code: 0 URL: http://reviewserver/r/1308/ Line: 500 Char: 7 Error: Object doesn't support this property or method Code: 0 URL: http://reviewserver/r/1308/
Is this still a problem in RC2? We committed some fixes for this.
-
+ NeedInfo -
- Priority-Medium + Priority-Critical + Milestone-Release1.6 -
+ chipx86
This is no longer an issue in RC2, feel free to close this.
-
- NeedInfo + Fixed