2157: Inner diff in draft generate 404 error
- Fixed
- Review Board
| hongb*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| hongb*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Jan. 22, 2014 | |
| 2460 |
What version are you running? 1.6RC1 What's the URL of the page containing the problem? http://demo.reviewboard.org/r/6333/diff/ 1. Login as "hongbin", password "hongbin" 2. Ask to generate diff between 1 and 2 What steps will reproduce the problem? 1. Did some change and committed. 2. post-review. published. 3. ran git reset head~1 --soft 4. Did another change and committed. 5. post-review again. 6. Asked to generated inner diff in GUI. What is the expected output? What do you see instead? Expected to see inner diff, but an 404 error. What operating system are you using? What browser? Win7/Chrome Please provide any additional information below. Pls note that the inner diff displayed very well, after the review request was published. The error only occurred in draft.
The URL listed there is mighty odd...
Yes, the URL looks strange, but it was get by rendering diff. The followings step can get to the URL: 1. Go to http://demo.reviewboard.org/r/6333/diff/ 2. Login as "hongbin", password "hongbin" 3. Ask to generate diff between 1 and 2
Clicking on the "r1" on that page (to get an interdiff between r1 and r2) takes me to http://demo.reviewboard.org/r/6333/diff/1-2/#index_header and works just fine.
No idea why it worked on your side. The attached video shows it didn't work....
-
+
-
+ hongb*****@gmai***** (Google Code)
Huh. I get the same thing if I follow the same procedure as shown in the video (first look at r1, then look at the interdiff)
-
+ Component-DiffViewer