2137: just "Submitter" of a patch can add newer patches

o3s****@gmai***** (Google Code) (Is this you? Claim this profile.)
June 16, 2011 
What version are you running?
1.5.5

What steps will reproduce the problem?
1. Open a review request as user a
2. User b is handed over the patch, and enhances it.
3. User b uploads a new patch
4. to User b there is no feedback what happened to his upload
5. User a now finds [Draft] next to that review on the subject, he can now comment and publish the upload.

What is the expected output? What do you see instead?
either one of these should apply:
 - user b shouldn't be allowed to upload patches at all
 - user b should be able to complete the upload procedure (depending on maybe settings / privileges?)
 - user a should at least get a mail that somebody added a patch to his review, which he should permit or decline; user b gets the chance to input his comment, and gets a note that user a needs to permit his request
chipx86
#1 chipx86 
User B, in your case, is an admin and can do anything. A normal user B could never modify another person's review request. This is just a special admin privilege that is really just for correcting problems, and probably should be disabled by default anyway.
  • +NotABug
  • +Component-Reviews
#2 o3s****@gmai***** (Google Code) (Is this you? Claim this profile.) 
You're right, the user has 'Can add diffset'-permissions.
but whats the point in uploading a diff if you can't publish it?