2102: "Ship it" false positive during review submission

bela.******@gmai***** (Google Code) (Is this you? Claim this profile.)
May 16, 2011 
ReviewBoard 1.5.5
URL: https://reviewboard.eng.vmware.com/r/%d/
Steps:

1. Click "Review"
2. Enter some text
3. Leave "[ ] Ship it" UN-checked
4. Put mouse cursor on "Publish Review"
5. Put eyes on "[ ] Ship it" button
6. Click (thus performing "Publish Review")
7. Observe that "[v] Ship it" appears (a grey "check mark") while the submission is happening
8. Observe that the review that's emailed out and posted does *not* say "Ship it"

Expected: (a) "[ ] Ship it" button does not temporarily claim to be checked; (b) resulting review does not say "Ship it!"
Actual: (a) button *does* temporarily and heart-stoppingly claim to be checked; (b) resulting review correctly does not say "Ship it!"

Therefore this is a cosmetic, not functional bug; but could easily cause human action (like posting another review saying "Ignore the ship it on that last review, it got turned on by mistake somehow" when in fact that didn't really happen).

OS: Ubuntu 9.10 x86_64
Browser: Opera 11.10

COUNTEREXAMPLE: tried with IE8, Win XP SP3 x86_32, checkmark did not appear.  Therefore, some degree of browser interaction.
#1 bela.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
BTW, this is similar to issue 788, however 788 appears to have been talking about "Ship it" actually being turned on in the submitted review, not just briefly *displayed* as on during submission.
chipx86
#2 chipx86 
It's actually a browser bug. We don't do anything but disable the entry. Opera is drawing the disabled state with the checkbox, which is very much a bug on their end.

Certainly an annoying one, but I don't think we can do anything about it.
  • +ThirdParty
  • +Browser