2086: postreview unhandled exception

matt.n******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 8, 2012
What version are you running?
RBTools 0.3.2
Review Board 1.5.4 

What steps will reproduce the problem?
1. edited some minor changes in https://github.com/bb-generation/gobby/blob/gobby-infinote/code/core/preferences.cpp and the corresponding header file in a new branch
2. tried to create a new review-request using "post-review --parent=<oldbranch>"

What is the expected output? What do you see instead?
review request XX posted

Instead:
Traceback (most recent call last):
  File "/usr/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.3.2', 'console_scripts', 'post-review')()
  File "/usr/lib/python2.7/site-packages/rbtools/postreview.py", line 3795, in main
    submit_as=options.submit_as)
  File "/usr/lib/python2.7/site-packages/rbtools/postreview.py", line 3461, in tempt_fate
    parent_diff_content)
  File "/usr/lib/python2.7/site-packages/rbtools/postreview.py", line 769, in upload_diff
    fields, files)
  File "/usr/lib/python2.7/site-packages/rbtools/postreview.py", line 983, in api_post
    return self.process_json(self.http_post(path, fields, files))
  File "/usr/lib/python2.7/site-packages/rbtools/postreview.py", line 904, in http_post
    data = urllib2.urlopen(r).read()
  File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 392, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 410, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 370, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1197, in http_open
    return self.do_open(httplib.HTTPConnection, req)
  File "/usr/lib/python2.7/urllib2.py", line 1166, in do_open
    h.request(req.get_method(), req.get_selector(), req.data, headers)
  File "/usr/lib/python2.7/httplib.py", line 941, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 975, in _send_request
    self.endheaders(body)
  File "/usr/lib/python2.7/httplib.py", line 937, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 795, in _send_output
    msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 787: ordinal not in range(128)
david
#1 david
I think this is fixed in newer post-reviews
  • +Fixed