2079: ReviewBoard show broken Git diff with broken extra whitespace
- UnableToReproduce
- Review Board
| Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Feb. 13, 2012 |
In which versions problem occure? 1.5.2 and above. 1.5.1 is latest working version. What's the URL of the page containing the problem? https://reviewboard.instance/r/1/diff/#index_header What steps will reproduce the problem? 1. Send diff using rbtools $post-review -n --revision-range="master:branch" --server https://reviewboard.instance/ diff --git a/file b/file index f73f3093ff865c514c6c51f867e35f693487d0d3..d5c30b39ef22c82bb6d9cabbb60dd485dd63cbbc 100644 --- a/file +++ b/file @@ -1 +1,4 @@ file +file +file +file 2. Visit URL which generated review diff https://reviewboard.instance/r/1/diff/#index_header 3. With "Hide Extra WhiteSpace" turned on you see something like that (screenshot attached) What operating system are you using? What browser? Google Chrome - Windows ReviewBoard - Linux
I checked using git bisect which commit introduced a bug. It was:
a018748e0c92dc46ec19c2137f94e5ca051e7df5 is the first bad commit
commit a018748e0c92dc46ec19c2137f94e5ca051e7df5
Author: Mikhail Rogozhin <mikhail.rogozhin@gmail.com>
Date: Wed Dec 15 23:11:26 2010 -0800
Fix extra whitespace highlight toggling
Make whitespace highlight toggling work in diffs which are loaded
asynchroniusly. Elements with class "ew" will be highlighted depending on their
ancestor element class.
Tested on Chromium 6.0, Firefox 3.6.12, IE 8
:040000 040000 363ce855cf8fbaeca8d1b6df8060d76c9a6f4734 f3a742d7545fd639cabdaad8cb6ecc8857c876f8 M reviewboard
It is ok. This is very old issue. As far as I can remember - it start working right later. By the way, great work! :)